Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

37 add api #39

Merged
merged 21 commits into from
Mar 20, 2024
Merged

37 add api #39

merged 21 commits into from
Mar 20, 2024

Commits on Jan 30, 2024

  1. Added IMD api functions

    @Lextuga007
    Lextuga007 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b82a10d View commit details
    Browse the repository at this point in the history

  2. Added test to check for no message if postcodes are correct

    @Lextuga007
    Lextuga007 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7168ca7 View commit details
    Browse the repository at this point in the history

  3. Replaced get_imd_api code with {httr2} from 

    https://gist.github.com/francisbarton/5d9d177978a2279cf225abdc772adef9
    @Lextuga007
    Lextuga007 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3b7068a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Moved into specific functions

    @Lextuga007
    Lextuga007 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    02ccf8a View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Added is_lsoa function

    @Lextuga007
    Lextuga007 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    49d6908 View commit details
    Browse the repository at this point in the history

  2. Tidied package

    @Lextuga007
    Lextuga007 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    13ec67c View commit details
    Browse the repository at this point in the history

  3. Added error message if no postcode data present

    @Lextuga007
    Lextuga007 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5b131a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Added parameters for function from NHSRpostcodetools

    @Lextuga007
    Lextuga007 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3126a89 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Changed column to join on to NULL, created var within function, messa… 

    …ges for missing data, added joins to original data
    @Lextuga007
    Lextuga007 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2c2a0b1 View commit details
    Browse the repository at this point in the history

  2. Amended tests

    @Lextuga007
    Lextuga007 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    59ee8ff View commit details
    Browse the repository at this point in the history

  3. Debugged the df output code so all rows returned from original data

    @Lextuga007
    Lextuga007 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2c47697 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Fixed issues with IMD API join and added mock tests

    @Lextuga007
    Lextuga007 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    74e1c37 View commit details
    Browse the repository at this point in the history

  2. Ran styler and linter

    @Lextuga007
    Lextuga007 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ea7349e View commit details
    Browse the repository at this point in the history

  3. Rewrote vignette and updated tests

    @Lextuga007
    Lextuga007 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    5fbebe8 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Commented out assert messages to allow for different colm names. Fixe… 

    …d tests
    @Lextuga007
    Lextuga007 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    745d39d View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Commented out assert messages to allow for different colm names. Fixe… 

    …d tests
    @Lextuga007
    Lextuga007 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ea7e311 View commit details
    Browse the repository at this point in the history

  2. Fixed bug in get_data() to allow for a different column name for imd

    @Lextuga007
    Lextuga007 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4536ec3 View commit details
    Browse the repository at this point in the history

  3. Resolved merge conflicts 

    Merge branch '37-add-api' of https://github.com/nhs-r-community/NHSRpopulation into 37-add-api

# Conflicts:
#	R/get_data.R
#	tests/testthat/test-get_data.R
#	vignettes/NHSRpopulation.Rmd
    @Lextuga007
    Lextuga007 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    dcac90e View commit details
    Browse the repository at this point in the history

  4. Corrected vignette data object name

    @Lextuga007
    Lextuga007 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c2c12ab View commit details
    Browse the repository at this point in the history

  5. Updated pkgdown and github actions

    @Lextuga007
    Lextuga007 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b646b7c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Pre-computed vignette https://ropensci.org/blog/2019/12/08/precompute… 

    …-vignettes/
    @Lextuga007
    Lextuga007 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1075222 View commit details
    Browse the repository at this point in the history