Make selection{Start,End,Direction} no longer throw when non-applicable

This keeps up with a recent spec change: whatwg/html#1006.
nhunzaker · Dec 22, 2016 · 8007da1 · 8007da1
1 parent 10df58d
commit 8007da1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/lib/jsdom/living/nodes/HTMLInputElement-impl.js b/lib/jsdom/living/nodes/HTMLInputElement-impl.js
@@ -231,7 +231,7 @@ class HTMLInputElementImpl extends HTMLElementImpl {
 
   get selectionStart() {
     if (!allowVariableLengthSelection(this.type)) {
-      throw new DOMException(DOMException.INVALID_STATE_ERR);
+      return null;
     }
 
     return this._selectionStart;
@@ -247,7 +247,7 @@ class HTMLInputElementImpl extends HTMLElementImpl {
 
   get selectionEnd() {
     if (!allowVariableLengthSelection(this.type)) {
-      throw new DOMException(DOMException.INVALID_STATE_ERR);
+      return null;
     }
 
     return this._selectionEnd;
@@ -263,7 +263,7 @@ class HTMLInputElementImpl extends HTMLElementImpl {
 
   get selectionDirection() {
     if (!allowVariableLengthSelection(this.type)) {
-      throw new DOMException(DOMException.INVALID_STATE_ERR);
+      return null;
     }
 
     return this._selectionDirection;

diff --git a/lib/jsdom/living/nodes/HTMLInputElement.idl b/lib/jsdom/living/nodes/HTMLInputElement.idl
@@ -53,9 +53,9 @@ interface HTMLInputElement : HTMLElement {
 //  [SameObject] readonly attribute NodeList labels;
 
   void select();
-  attribute unsigned long selectionStart;
-  attribute unsigned long selectionEnd;
-  attribute DOMString selectionDirection;
+  attribute unsigned long? selectionStart;
+  attribute unsigned long? selectionEnd;
+  attribute DOMString? selectionDirection;
   void setRangeText(DOMString replacement);
   void setRangeText(DOMString replacement, unsigned long start, unsigned long end, optional SelectionMode selectionMode = "preserve");
   void setSelectionRange(unsigned long start, unsigned long end, optional DOMString direction);

diff --git a/lib/jsdom/living/nodes/HTMLTextAreaElement.idl b/lib/jsdom/living/nodes/HTMLTextAreaElement.idl
@@ -30,9 +30,9 @@ interface HTMLTextAreaElement : HTMLElement {
 //  [SameObject] readonly attribute NodeList labels;
 
   void select();
-  attribute unsigned long selectionStart;
-  attribute unsigned long selectionEnd;
-  attribute DOMString selectionDirection;
+  attribute unsigned long? selectionStart;
+  attribute unsigned long? selectionEnd;
+  attribute DOMString? selectionDirection;
   void setRangeText(DOMString replacement);
   void setRangeText(DOMString replacement, unsigned long start, unsigned long end, optional SelectionMode selectionMode = "preserve");
   void setSelectionRange(unsigned long start, unsigned long end, optional DOMString direction);