Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS API Refactor Acceptance Conditions #466

Open
1 of 6 tasks
rajsite opened this issue Jun 27, 2018 · 0 comments
Open
1 of 6 tasks

JS API Refactor Acceptance Conditions #466

rajsite opened this issue Jun 27, 2018 · 0 comments

Comments

@rajsite
Copy link
Member

rajsite commented Jun 27, 2018 •
edited
Loading

Things we should review across all the api functions implemented to make consistent prior to submission:

  • Input validation of valueRef
  • Robustness of stackSave / restore and error recovery the api should enable
  • Input validation responsibility or JS layer vs vs CPP layer (ie validate array of numbers for dimensions iput or value of string for readString)
  • Consistent marking of parameters as const on the CEntryPoints
  • Validation of the TypeManager input in CEntryPoint functions (null check or better)
  • Modify findValueRef and findSubValueRef to return undefined if path does not resolve to a value instead of throwing - update lookupLocalBindingInfo in Mainline
This was referenced Jun 27, 2018
Merged
Merged
rajsite added a commit that referenced this issue Jul 13, 2018
@rajsite
Vireo EggShell Refactor for Supporting More Types (#471)
8bdcb79 
Implementation of "Vireo API Changes for Supporting More Types Design Doc"

This change encapsulates the breaking API changes associated with the Vireo API refactor. There is still additional work to be done out of master after the change is merged consisting of:

1. Making error checks and error handling consistent across all of the new api functions: #466

2. Migrating the following JavaScript users of the now deprecated API functions to the new API functions: HttpClient, JavaScriptInvoke, Core (FPSync, LV Error Handling), Events.

3. Removing the deprecated API functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rajsite