Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @types/markdown-it to aligned and pinned version #2326

Open
rajsite opened this issue Aug 2, 2024 · 1 comment
Open

Update @types/markdown-it to aligned and pinned version #2326

rajsite opened this issue Aug 2, 2024 · 1 comment
Labels
blocked Blocked on a third-party issue tech debt

Comments

@rajsite
Copy link
Member

rajsite commented Aug 2, 2024

🧹 Tech Debt

The @types/markdown-it updates were disabled due to an issue in prosemirror-markdown, see ProseMirror/prosemirror-markdown#124

When addressed we can re-enable the updates and switch from @types/markdown-it v13 to v14 (which we actually end up relying on v14 of the actual markdown-it library transitively due to prosemirror-markdown).

Additional discussion here: #2318 (comment)
@rajsite rajsite added tech debt triage New issue that needs to be reviewed labels Aug 2, 2024
@rajsite rajsite added the blocked Blocked on a third-party issue label Aug 2, 2024
@rajsite rajsite mentioned this issue Aug 2, 2024
Merged
1 task
rajsite added a commit that referenced this issue Aug 2, 2024
@rajsite
Disable markdown-it types update (#2327)
92d964e 
# Pull Request

## 🤨 Rationale

The `@types/markdown-it` updates were disabled due to an issue in
prosemirror-markdown. See #2326

## 👩‍💻 Implementation

Disabled `@types/markdown-it` in the renovate config.

## 🧪 Testing

Will see if the renovate merge PR is successful after.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@rajsite rajsite added blocked Blocked on a third-party issue and removed blocked Blocked on a third-party issue labels Aug 5, 2024
@rajsite rajsite changed the title Enable @types/markdown-it updates in renovate Update @types/markdown-it to aligned and pinned version Aug 5, 2024
@rajsite
Copy link
Member Author

rajsite commented Aug 5, 2024 •
edited
Loading

ProseMirror/prosemirror-markdown#124 was merged but we are still blocked on release. After release the pinned version of @types/markdown-it should be updated to align with the version of markdown-it used by prosemirror-markdown.

Unfortunately we should not enable renovate as we need to manually align the @types/markdown-it version to what is used by our version of prosemirror-markdown so it should be a manual task added to #1747.

@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked on a third-party issue tech debt
Projects
Nimble Design System Priorities
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rajsite @m-akinc