-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump lockfile versions for Beachball #41
Comments
Fixed with main.yml and package.json changes in compare range: 0b923ee...cfafcd4 |
@jattasNI want to do a quick sanity check of these commits that were direct to master (to sanity check build) before closing this issue? edit: nvm, spoke too soon, looks like it broke something: https://github.com/ni/nimble/runs/3204626431 |
Reverted the changes and commented on the linked fast issue. Another thing to try is letting beachball publish and push as-is, then sync main to pull in the beachball changes, do the |
@jattasNI Went on a test spree and got it working with a change in main.yml. Could you take a look and see if you have any feedback? If beachball adds native npm workspaces support in the future then we can remove the workaround. |
@rajsite your changes to publish I am surprised beachball isn't taking that issue more seriously--it seems like a major gap to me but the issue isn't getting much discussion. If you can think of a way to nudge them on it (file a new issue? tag the maintainers?) that might be a good step. |
Looks like fast is considering switching to npm 7 so I threw in a comment describing our use case there: microsoft/fast#4737 (comment) I'll close this issue since we have a form of publishing the lock file working. Hopefully we can remove the workaround in the future. |
Beachball will bump package.json versions on publish but will not result in package-lock.json changes.
This causes local npm installs to result in dirty package-locks which get included in PR reviews. This increases the chance of unnecessary merge conflicts in the package-lock.json.
Beachball issue: microsoft/beachball#525 (comment)
The text was updated successfully, but these errors were encountered: