-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Karma Infrastructure #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotia673
reviewed
Jul 28, 2021
scotia673
reviewed
Jul 28, 2021
scotia673
approved these changes
Jul 28, 2021
jattasNI
approved these changes
Jul 28, 2021
haworthia
reviewed
Jul 28, 2021
rajsite
commented
Jul 29, 2021
@jattasNI resetting you as there was some big folder structure changes and to check the fixture docs |
jattasNI
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Introduces karma test infrastructure for writing unit tests. Modeled after the integration in fast foundation.
This does not integrate the playwright-based FAST e2e testing framework.
👩💻 Implementation
Migrated a similar karma configuration as used in FAST with some differences:
Some other minor refactors included in this change:
importsNotUsedAsValues
TypeScript compiler rule for nimble components. This is helpful as nimble components currently relies on side-effects of imports and as a result of enabling the rule it becomes explicit when an import is done for side-effects instead of just for type imports, ieimport './someFile';
(note how there are no named imports, just side-effects).🧪 Testing
Included a sample test file for the Button based on existing FastFoundation tests. Does not represent what the Button tests should cover but is just used as an example to test the infrastructure. In a follow-up the example tests should be replaced with tests for Nimble Button specific features (currently just appearance configuration).
✅ Checklist