Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make combobox and select dropdowns float above other UI #1244

Merged
merged 11 commits into from
May 23, 2023

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented May 15, 2023

Pull Request

🀨 Rationale

Fixes: #606
Fixes: #1227

πŸ‘©β€πŸ’» Implementation

I initially looked at using Floating-UI, as that is what FAST 2.0 is using to solve this problem. (see #1234) However, for consistency, that would require adding support to both the Select/Combobox as well as updating the menu button, the menu item (for submenu support), and the tooltip. Each case was a significant change, and I ran into several problems, including with the action menu in the table. It turned into a 40+ file change with a lot of risk. I sunk more time into it than I wanted, and still didn't feel close to done. I'm instead taking a much more scoped approach of extending the existing pattern and using the anchored region in the Select and Combobox.

This required forking the templates for both controls from FAST, so that we could add the anchored region element.

πŸ§ͺ Testing

I added some tests to cover certain expectations about the templates, e.g. attribute forwarding. I'm relying mostly on existing Chromatic tests to ensure the listbox pops up in the same place given the position options.

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc requested review from jattasNI and rajsite May 18, 2023 18:20
@m-akinc m-akinc merged commit e9f0332 into main May 23, 2023
@m-akinc m-akinc deleted the users/makinc/floating-dropdown2 branch May 23, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select popup stops on DIV - strange overflow behavior Select dropdown should float above other elements
4 participants