Add formatting API to date column #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
requested changes
Jul 24, 2023
packages/nimble-components/src/table-column/date-text/cell-view/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/cell-view/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/cell-view/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/group-header-view/index.ts
Outdated
Show resolved
Hide resolved
mollykreis
reviewed
Jul 25, 2023
packages/nimble-components/src/table-column/date-text/cell-view/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/cell-view/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts
Show resolved
Hide resolved
mollykreis
reviewed
Jul 26, 2023
mollykreis
approved these changes
Jul 26, 2023
jattasNI
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Thank you @m-akinc and @mollykreis for using the new "peer review" process. It felt a lot quicker to review this PR and the discussions you already had looked really productive.
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/models/format-helper.ts
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.stories.ts
Show resolved
Hide resolved
change/@ni-nimble-components-8fdb7efd-10a8-4e79-9dd7-079527db6644.json
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Jul 27, 2023
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts
Show resolved
Hide resolved
rajsite
approved these changes
Aug 1, 2023
packages/nimble-components/src/table-column/date-text/cell-view/index.ts
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/group-header-view/index.ts
Show resolved
Hide resolved
packages/nimble-components/src/table-column/date-text/tests/types.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Part of #1014
Adding ability to customize formatting of dates/times.
👩💻 Implementation
formatattribute and nineteen other custom formatting configuration attributes🧪 Testing
Unit tests pass, and tested manually in Storybook.
✅ Checklist