-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locale support to theme provider and use in date-text column #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
reviewed
Aug 1, 2023
change/@ni-nimble-components-df093e6a-7cba-46ed-8d5d-07670af90719.json
Outdated
Show resolved
Hide resolved
mollykreis
reviewed
Aug 1, 2023
m-akinc
changed the title
Add locale support to date-text column
Add locale support to theme provider and use in date-text column
Aug 2, 2023
mollykreis
approved these changes
Aug 2, 2023
msmithNI
requested changes
Aug 2, 2023
m-akinc
commented
Aug 4, 2023
rajsite
reviewed
Aug 5, 2023
mollykreis
reviewed
Aug 7, 2023
packages/nimble-components/src/theme-provider/tests/theme-provider.spec.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/theme-provider/tests/theme-provider.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: mollykreis <[email protected]>
rajsite
reviewed
Aug 7, 2023
rajsite
reviewed
Aug 10, 2023
rajsite
reviewed
Aug 17, 2023
msmithNI
approved these changes
Aug 30, 2023
jattasNI
reviewed
Aug 31, 2023
packages/nimble-components/src/theme-provider/tests/theme-provider.mdx
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/theme-provider/tests/theme-provider.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/theme-provider/tests/theme-provider.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/theme-provider/tests/theme-provider.spec.ts
Show resolved
Hide resolved
packages/nimble-components/src/theme-provider/tests/theme-provider.spec.ts
Show resolved
Hide resolved
…ider.mdx Co-authored-by: Jesse Attas <[email protected]>
rajsite
reviewed
Aug 31, 2023
packages/nimble-components/src/theme-provider/tests/theme-provider.stories.ts
Outdated
Show resolved
Hide resolved
mollykreis
reviewed
Aug 31, 2023
packages/nimble-components/src/theme-provider/tests/theme-provider.spec.ts
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Sep 1, 2023
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/theme-provider/tests/theme-provider.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/theme-provider/tests/theme-provider.stories.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Sep 1, 2023
packages/nimble-components/src/theme-provider/tests/theme-provider.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Attas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fixes #1293
Part of #1014
Adding design token ("lang") for locale and honoring that token's value when formatting dates in the date-text column.
👩💻 Implementation
lang
property, if valid, otherwise uses "en-US"DocumentElementLang
singleton watches page element'slang
propertylang
property to theme provider which sets design token value🧪 Testing
Unit tests pass (even when system locale is something other than 'en').
✅ Checklist