-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of nimble-table-column-number-text #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for format=default/integer/decimal, and decimalDigits, plus Storybook page
msmithNI
approved these changes
Aug 2, 2023
packages/nimble-components/src/table-column/number-text/tests/table-column-number-text.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Aug 3, 2023
packages/nimble-components/src/table-column/number-text/models/format-helper.ts
Outdated
Show resolved
Hide resolved
Moving this PR back to draft to address some formatting changes discussed in person:
I will also update the HLD to reflect these changes. |
atmgrifter00
reviewed
Aug 9, 2023
...ges/nimble-components/src/table-column/number-text/tests/table-column-number-text.stories.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Aug 9, 2023
…table-column-number-text.stories.ts Co-authored-by: Jonathan Meyer <[email protected]>
mollykreis
commented
Aug 11, 2023
packages/nimble-components/src/table-column/number-text/models/default-formatter.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/number-text/models/default-formatter.ts
Outdated
Show resolved
Hide resolved
...ges/nimble-components/src/table-column/number-text/tests/table-column-number-text.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/number-text/models/integer-formatter.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Aug 11, 2023
atmgrifter00
approved these changes
Aug 16, 2023
rajsite
approved these changes
Aug 16, 2023
packages/nimble-components/src/table-column/number-text/tests/table-column-number-text.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Aug 16, 2023
...ble-components/src/table-column/number-text/tests/table-column-number-text-matrix.stories.ts
Show resolved
Hide resolved
jattasNI
reviewed
Aug 16, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Show resolved
Hide resolved
...ges/nimble-components/src/table-column/number-text/tests/table-column-number-text.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/number-text/tests/table-column-number-text.spec.ts
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
This is part of #1011
This PR adds the initial implementation of the
nimble-table-column-number-text
with configuration to render the number using a default formatter or as an integer.There are a number of additional configurations that still need to be added to the column, such as:
👩💻 Implementation
The new column follows the same patterns as other table columns in nimble and uses the existing
TableColumnTextCellViewBase
andTableColumnTextGroupHeaderViewBase
.More interesting/complex implementation will come in future PRs.
🧪 Testing
✅ Checklist