Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular/Blazor integration for duration table column #1619

Merged
merged 13 commits into from
Oct 26, 2023
Merged

Angular/Blazor integration for duration table column #1619

merged 13 commits into from
Oct 26, 2023

Conversation

msmithNI
Copy link
Contributor

@msmithNI msmithNI commented Oct 23, 2023 •
edited
Loading

Pull Request

🤨 Rationale

Angular/Blazor integration for duration table column. Part of #1598

👩‍💻 Implementation

  • Standard Angular/Blazor integration. The duration column has no inputs specific to that column type so the API is just the shared properties for grouping/column widths/etc.
  • Added new DurationPipe at new pipes entrypoint in nimble-angular
  • Include duration column in nimble-components all-components bundle (Blazor example apps use that bundle so that's when we usually catch omissions in it)

🧪 Testing

  • Tested in local builds
  • Added autotests
  • Added duration column to component demo page in Angular/Blazor example apps

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@msmithNI msmithNI requested a review from m-akinc October 23, 2023 20:46
@msmithNI
Copy link
Contributor Author

@m-akinc can you buddy this PR?

@msmithNI msmithNI marked this pull request as ready for review October 23, 2023 23:28
@msmithNI msmithNI merged commit 244e2ca into main Oct 26, 2023
8 checks passed
@msmithNI msmithNI deleted the duration-column-angular-blazor branch October 26, 2023 00:05
@msmithNI msmithNI mentioned this pull request Oct 26, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jattasNI jattasNI jattasNI approved these changes

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

@m-akinc m-akinc m-akinc approved these changes

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msmithNI @rajsite @m-akinc @jattasNI @atmgrifter00