Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevate console warn and error to test failure and component lifecycle clean-up #1748

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Jan 11, 2024

Pull Request

🤨 Rationale

Fixes a couple of small issues noticed recently:

  • Tests were printing out console warnings
  • Some component callback lifecycles were not calling their super implementation
  • When test failures happened the current spec would stop making it difficult to see all the failures and handle them

👩‍💻 Implementation

  • Elevated console warn and console errors to test failures
  • Updated lifecycle callbacks to call super (and renamed some methods that weren't actually lifecycle callbacks, which was my idea, I was wrong 😅). Created a Manual Regression Validation issue to hopefully track that a little better in the future: Manual Recurring Maintenance Tasks #1747
  • Updated the jasmine configuration to continue running a test suite even on failure. We can see if it is useful and easily switch back if it is annoying. Was useful locally.
  • Filed an issue for some Wafer Map tests that are running incorrectly: WaferMap test expectations are not executing #1746

🧪 Testing

Rely on CI.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite enabled auto-merge (squash) January 12, 2024 16:13
@rajsite rajsite disabled auto-merge January 16, 2024 20:42
@rajsite
Copy link
Member Author

rajsite commented Jan 16, 2024

overriding owners @atmgrifter00 @DStavilaNI @zszilagy
please review when you get a chance and can address in follow-up

@rajsite rajsite merged commit 87f54f7 into main Jan 16, 2024
10 checks passed
@rajsite rajsite deleted the manual-checks branch January 16, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants