Update Angular and Blazor label provider directives to match nimble-components #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
changed the title
rajsite
reviewed
Mar 13, 2024
.../ni/nimble-angular/label-provider/core/nimble-label-provider-core-with-defaults.directive.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 13, 2024
.../ni/nimble-angular/label-provider/core/nimble-label-provider-core-with-defaults.directive.ts
Outdated
Show resolved
Hide resolved
jattasNI
changed the title
rajsite
approved these changes
Mar 13, 2024
.../ni/nimble-angular/label-provider/core/nimble-label-provider-core-with-defaults.directive.ts
Outdated
Show resolved
Hide resolved
...angular/label-provider/core/tests/nimble-label-provider-core-with-defaults.directive.spec.ts
Outdated
Show resolved
Hide resolved
change/@ni-nimble-angular-bb7e376e-ce72-4760-bb8d-f5775b8eefa8.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Milan Raj <[email protected]>
1 task
|
Bypassed owner review policy because Blazor owners @msmithNI and @atmgrifter00 are out of office and Blazor changes were mechanical. All other policies were satisfied. FYI @rajsite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
#1747 has a maintenance task to ensure the default strings in Angular and Blazor directives match the default strings in nimble-components.
👩💻 Implementation
Some labels were only provided in nimble-components, not nimble-angular or Blazor. Copied those values over following existing patterns in directives and test files.
🧪 Testing
Updated tests but otherwise none since this is a mechanical change.
✅ Checklist