Update some 3rd party dependencies to latest and re-enable 'npm audit' #589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Fixes #581. We had disabled
npm audit
in our pipelines because of the vulnerability, but beachball published a fix this weekend: microsoft/beachball#666.π©βπ» Implementation
npm audit
commands inmain.yml
. This revealed new vulnerabilities in severaldevDependencies
:ejs
,event-source
, andjson-schema
.npm update
for each of the above dependencies and alsojsprim
, which was needed to get the fixedjson-schema
(jsprim
pins its deps to exact versions)I looked into npm overrides which are intended for this purpose but they're not ready for prime time (poorly documented workspace support and bizarrely not usable with an existing package-lock.json with our current npm version.
π§ͺ Testing
Relying on pipeline.
β Checklist