Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ytmapi-rs Cargo.lock to .gitignore #27

Closed
nick42d opened this issue Apr 25, 2024 · 1 comment
Closed

Add ytmapi-rs Cargo.lock to .gitignore #27

nick42d opened this issue Apr 25, 2024 · 1 comment
Assignees
@nick42d
Labels
bug Something isn't working

Comments

@nick42d
Copy link
Owner

nick42d commented Apr 25, 2024

It's recommended to not check in lockfile for libraries (rust-lang/cargo#315), so we should add it to out .gitignore.
@nick42d nick42d added the bug Something isn't working label Apr 25, 2024
@nick42d nick42d self-assigned this Apr 25, 2024
@nick42d
Copy link
Owner Author

nick42d commented Apr 25, 2024

Helps with future contributors - e.g #26

nick42d added a commit that referenced this issue Apr 25, 2024
@nick42d
Git should ignore library Cargo.lock - resolves #27
85de03c
nick42d added a commit to hungl6844/youtui that referenced this issue Apr 26, 2024
@nick42d
Remove ytmapi-rs Cargo.lock and add it to .gitignore - resolves nick4…
bcc9b6f 
…2d#27
@github-actions github-actions bot mentioned this issue Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nick42d nick42d

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nick42d