This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
fixture: SetUpBefore()/TearDownAfter() #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I definitely see the utility in this, but I will need to consider the implications. This might be a breaking change I'm willing to introduce. Let me mull it over next week when I have some time. I appreciate the work! |
|
I haven't forgotten about this one. I'm head down in release mode right now, so it might be a minute before I get to it. I apologize. |
|
Geez. I forgot all about this one. Can you please remove the use of std::unique_ptr as we do want backwards compatibility for older projects with C++98? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my benchmarks need to load a huge amount of data and it takes very long time. Current SetUp() and even the constructor are executed before every run which makes those tests painfuly long.
The downside of this patch is that it is not fully backward compatible because it constructs the test instance only once for each BENCHMARK section.
I'd like to know your thoughts.