Simplify enum_variant_pattern rule #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of instantiating `patternF` manually, we can actually reuse the rule `pattern_fun` within the `enum_variant_pattern`, which makes things a bit more consistent and will help on the Topiary formatting side. Passing by, we also removed the unused last parameter passed to the various xxxF macro rules - this was copied from LALRPOP but doesn't make sense currently in the tree-sitter grammar. Fortunately (or not?) additional arguments are just ignored in JavaScript, so this shouldn't change anything in practice, but is less confusing to future readers of the grammar.
ErinvanderVeen
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of instantiating
patternFmanually, we can actually reuse the rulepattern_funwithin theenum_variant_pattern, which makes things a bit more consistent and will help on the Topiary formatting side.Passing by, we also removed the unused last parameter passed to the various xxxF macro rules - this was copied from LALRPOP but doesn't make sense currently in the tree-sitter grammar. Fortunately (or not?) additional arguments are just ignored in JavaScript, so this shouldn't change anything in practice, but is less confusing to future readers of the grammar.