Add support for namespaced primops #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
force-pushed
the
feat/namespaced-primops
branch
from
baa093c
to
795a119
Compare
yannham
force-pushed
the
fix/enum-variant-types
branch
from
c23aa86
to
170db27
Compare
Add support for enum variant in types
Nickel has change some primops to contain a forward slash `/`, which wasn't supported by the parser (they would be parsed as modulo instead). This commit extend the `builtin` rule to accepts a larger class of valid builtin names, including those new ones, and hopefully potential future ones as well.
yannham
force-pushed
the
feat/namespaced-primops
branch
from
795a119
to
71e702b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #46.
Nickel has changed some primops to contain a forward slash
/(see tweag/nickel#1937), which wasn't supported by the tree-sitter grammar (they would be parsed as modulo instead).This commit extends the
builtinrule to accepts a larger class of valid builtin names, including those new ones, and hopefully potential future ones as well.