Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new ember-modifiers syntax #323

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

nickschot
Copy link
Owner

This resolves the deprecations thrown by ember-modifier

See: https://github.com/ember-modifier/ember-modifier/blob/master/MIGRATIONS.md

@nickschot nickschot merged commit 837125c into master Sep 14, 2022
@nickschot nickschot deleted the upgrade-modifier-syntax branch September 14, 2022 20:22
@SergeAstapov
Copy link

@nickschot I think this should change "ember-modifier": "^3.0.0" in package.json to "ember-modifier": "^3.2.0" as otherwise this change would break apps using ember-modifier v3.1.0 or ember-modifier v3.0.0

Alternatively, this could be both backward and forward compatible with old and new API using @embroider/macros, e.g. like in https://github.com/DockYard/ember-in-viewport/pull/306/files#diff-90b347e9e07bc6b4b1cf6215b21e606557ae635d920b6bb349351912c4473fd1

@nickschot
Copy link
Owner Author

@nickschot I think this should change "ember-modifier": "^3.0.0" in package.json to "ember-modifier": "^3.2.0" as otherwise this change would break apps using ember-modifier v3.1.0 or ember-modifier v3.0.0

Alternatively, this could be both backward and forward compatible with old and new API using @embroider/macros, e.g. like in https://github.com/DockYard/ember-in-viewport/pull/306/files#diff-90b347e9e07bc6b4b1cf6215b21e606557ae635d920b6bb349351912c4473fd1

Whoops! Thanks for catching that. I'll fix that by bumping the dependency for now. Will look at the macros fix later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants