Workaround for snapshots for async rsc #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered what I believe is an issue when using snapshots with Vitest and React server components. The snapshots were being generated as an empty `<div />` tag. My workaround was to first perform some `screen` assertions (as shown in the test cases). After doing this, the snapshots are generated correctly when using `toMatchSnapshot`.
abel-castro
commented
Aug 23, 2024
|
Hi @nickserv! I realized there were some issues in the PR, which caused the GitHub Actions to fail. I have already fixed the problems with the latest commits. Please check it out when you have time. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered what I believe is an issue when using snapshots with Vitest and async react server components.
The snapshots were being generated as an empty
<div />tag. My workaround was to first perform somescreenassertions (as shown in the test cases).After doing this, the snapshots are generated correctly when using
toMatchSnapshot.As part of this PR, I also updated Vitest to a newer version (2.0.5), as I don't see any reason to stay in version 0.3.4.