Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unic #34

Merged
merged 12 commits into from
Oct 10, 2023
Merged

Replace unic #34

merged 12 commits into from
Oct 10, 2023

Conversation

chris-ha458
Copy link
Contributor

As mentioned before, i prepared a PR that replaces unic from the codebase.
a non exhaustive list of reasons to change :

  • it is not being developed or maintained anymore (in fact most if not all of the developers are responsible for icu4x atm)
  • it's unicode support is old. (10?)

Through this PR, now Unicode 15 is supported.

I haven't seen any regressions from --bin performance or cargo bench.
Since icu4x is actively being developed I expect that there would be more features including name or unicode ranges implementations or speedups. Unfortunately there is no speedup observed at the moment, but icu4x is actively tracking and performance regressions and striving to improve it as well.

Also I hope to make further idiomatic changes especially around the md module upon this platform.

I know this is a big change, but hopefully it will lead to easier development and reduced hardcoding down the road.

Take your time reviewing it and feel free to ask any questions.

@nickspring nickspring merged commit 7086072 into nickspring:main Oct 10, 2023
3 checks passed
@chris-ha458 chris-ha458 deleted the replace_unic branch November 23, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants