LibWeb: Prevent checkboxes from firing change events when losing focus

This is because toggling the checkbox is committing the value. (cherry picked from commit 3856dd946b94b61be2ddac80c8cf60278fcc56ab; amended to add two spaces to expected output due to serenity not yet having LadybirdBrowser/ladybird#1603, and to add a trailing newline to the test input file)
nico · Nov 18, 2024 · c915179 · c915179
1 parent 8da2929
commit c915179
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/Tests/LibWeb/Text/expected/checkbox-focus-lost-no-change-event.txt b/Tests/LibWeb/Text/expected/checkbox-focus-lost-no-change-event.txt
@@ -0,0 +1 @@
+
diff --git a/Tests/LibWeb/Text/input/checkbox-focus-lost-no-change-event.html b/Tests/LibWeb/Text/input/checkbox-focus-lost-no-change-event.html
@@ -0,0 +1,16 @@
+<!DOCTYPE html>
+<input type="checkbox" id="checkbox">
+<script src="include.js"></script>
+<script>
+    checkbox.addEventListener("change", () => {
+      println("Change event was fired when it shouldn't have been.");
+    });
+    asyncTest(async done => {
+        checkbox.focus();
+        await new Promise(resolve => setTimeout(resolve, 0));
+        checkbox.blur();
+        await new Promise(resolve => setTimeout(resolve, 0));
+
+        done();
+    });
+</script>
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
@@ -615,6 +615,7 @@ void HTMLInputElement::commit_pending_changes()
     case TypeAttributeState::Telephone:
     case TypeAttributeState::Text:
     case TypeAttributeState::URL:
+    case TypeAttributeState::Checkbox:
         if (!m_has_uncommitted_changes)
             return;
         break;