Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Filter values" input box not working in Internet Explorer 11 #850

Closed
co-operate opened this issue Jan 7, 2018 · 6 comments
Closed

"Filter values" input box not working in Internet Explorer 11 #850

co-operate opened this issue Jan 7, 2018 · 6 comments

Comments

@co-operate
Copy link

Just a heads up. Filtering values in the attribute bubble does, however, work in Microsoft Edge, Firefox and Chrome.

PS: And once more THANK YOU to Nicolas and all other contributors for this really outstanding piece of software!

@nicolaskruchten
Copy link
Owner

Thanks for the bug report! I'm not sure when this stopped working but I'll try to get it fixed soon!

@co-operate
Copy link
Author

co-operate commented Jan 9, 2018

Nicolas,

Sorry, I noticed this is a duplicate of issue #640.
The solution proposed there is to polyfill ".startsWith“, and it works lovely:

if (!String.prototype.startsWith) {
	String.prototype.startsWith = function(search, pos) {
		return this.substr(!pos || pos < 0 ? 0 : +pos, search.length) === search;
	};
};

Alternatively, there is a more robust polyfill by Mathias Bynens https://github.com/mathiasbynens/String.prototype.startsWith

@nicolaskruchten
Copy link
Owner

Oh, I didn't dig into that older issue as much as I should have :(

This is actually really easy to fix, I don't even need a polyfill, I'll just remove the calls to startsWith.

@co-operate
Copy link
Author

Even better :-)

@nicolaskruchten
Copy link
Owner

Let's leave this open until I've released a fix, though, please :)

nicolaskruchten added a commit that referenced this issue Jan 15, 2018
@nicolaskruchten
Copy link
Owner

Fix released in version 2.19.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants