Fix mmol Units for Therapy Event in NS #1094
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1085
But it's a workaround (I suppose root cause is a bug in NS or somewhere else in AAPS but I can't find it)
=> See informations below to help fix root cause (I don't like this kind of workaround...)
When BG value (
glucose
) associated to a therapyEvent is in mmol unit, there are 2 additional entries in json string (targetTop
andtargetBottom
).These 2 entries are null but when added, glucose units (
mmol
) is replaced bymg\/dl
in json string so units is wrong forglucose
value in received json string.json string received for BG Check if units is mgdl:
json string received for BG Check if units is mmol: