Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pebble MMOL settings issues #396

Closed
sulkaharo opened this issue Feb 2, 2015 · 8 comments
Closed

Pebble MMOL settings issues #396

sulkaharo opened this issue Feb 2, 2015 · 8 comments

Comments

@sulkaharo
Copy link
Member

http://www.nightscout.info/wiki/welcome/website-features says DISPLAY_UNITS = mmol doesn't apply to the Pebble and that seems to be the case.

The Pebble watchface has a units setting, but it doesn't actually change the units that are displayed, only the units used to configure the warnings. How the units are actually configured is not documented.

The undocumented way to get the data in mmols is by appending ?units=mmol to the end of the data source URL.

Things to do (?):

  • Have DISPLAY_UNITS actually affect Pebble
  • Have the API send over the units used for the data
  • Have the setting in the watch face config actually change the units shown if changed to be different from the default
@ELUTE
Copy link
Contributor

ELUTE commented Feb 2, 2015

Appending ?units=mmol is documented. Both in the pebble config itself and nightscout.info site.

On Feb 2, 2015, at 3:53 PM, Sulka Haro [email protected] wrote:

http://www.nightscout.info/wiki/welcome/website-features http://www.nightscout.info/wiki/welcome/website-features says DISPLAY_UNITS = mmol doesn't apply to the Pebble and that seems to be the case.

The Pebble watchface has a units setting, but it doesn't actually change the units that are displayed, only the units used to configure the warnings. How the units are actually configured is not documented.

The undocumented way to get the data in mmols is by appending ?units=mmol to the end of the data source URL.

Things to do (?):

Have DISPLAY_UNITS actually affect Pebble
Have the API send over the units used for the data
Have the setting in the watch face config actually change the units shown if changed to be different from the default

Reply to this email directly or view it on GitHub #396.

@sulkaharo
Copy link
Member Author

I guess there's multiple pebble pages for the watchface in that case? The page linked to from the docs, which I used as reference, doesn't mention this.


Sent from Mailbox

On Mon, Feb 2, 2015 at 11:39 PM, Kate Farnsworth [email protected]
wrote:

Appending ?units=mmol is documented. Both in the pebble config itself and nightscout.info site.

On Feb 2, 2015, at 3:53 PM, Sulka Haro [email protected] wrote:

http://www.nightscout.info/wiki/welcome/website-features http://www.nightscout.info/wiki/welcome/website-features says DISPLAY_UNITS = mmol doesn't apply to the Pebble and that seems to be the case.

The Pebble watchface has a units setting, but it doesn't actually change the units that are displayed, only the units used to configure the warnings. How the units are actually configured is not documented.

The undocumented way to get the data in mmols is by appending ?units=mmol to the end of the data source URL.

Things to do (?):

Have DISPLAY_UNITS actually affect Pebble
Have the API send over the units used for the data
Have the setting in the watch face config actually change the units shown if changed to be different from the default

Reply to this email directly or view it on GitHub #396.


Reply to this email directly or view it on GitHub:
#396 (comment)

@jasoncalabrese
Copy link
Member

We should fix the pebble to use the DISPLAY_UNITS setting, the units parameter could be an override

@YYGIRL
Copy link

YYGIRL commented Feb 4, 2015

It would break backwards compatibility. Many people still use versions that
don't have a config file. Plus we don't have room in the message going down
to the watch.

On Tue, Feb 3, 2015 at 7:25 PM, Jason Calabrese [email protected]
wrote:

We should fix the pebble to use the DISPLAY_UNITS setting, the units
parameter could be an override


Reply to this email directly or view it on GitHub
#396 (comment)
.

Join the Jack Attack!
Fight Type 1 Diabetes
_Give to the JDRF - _www.jdrf.org http://www.jdrf.org

@jasoncalabrese
Copy link
Member

Think a typo in my comment confused things, the pebble endpoint should use the DISPLAY_UNITS setting, for backwards compatibility we can still support the units parameter.

@YYGIRL
Copy link

YYGIRL commented Feb 4, 2015

Got it, thanks.

On Tue, Feb 3, 2015 at 7:55 PM, Jason Calabrese [email protected]
wrote:

Think a typo in my comment confused things, the pebble endpoint should
use the DISPLAY_UNITS setting, for backwards compatibility we can still
support the units parameter.


Reply to this email directly or view it on GitHub
#396 (comment)
.

Join the Jack Attack!
Fight Type 1 Diabetes
_Give to the JDRF - _www.jdrf.org http://www.jdrf.org

@jasoncalabrese jasoncalabrese added this to the enchilada milestone Mar 18, 2015
@jasoncalabrese
Copy link
Member

Think this is done, but we should verify

@jasoncalabrese
Copy link
Member

I verified that this is done, the DISPLAY_UNITS env is used in /pebble now so your don't need to use ?units=mmol anymore. If it's set it will work as an override.

@ELUTE, @jimsiff, can we update the docs to remove ?units=mmol and have users set DISPLAY_UNITS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants