Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prediction cone values are different in MMOL setting #402

Closed
baswieb opened this issue Feb 8, 2015 · 3 comments
Closed

Prediction cone values are different in MMOL setting #402

baswieb opened this issue Feb 8, 2015 · 3 comments
Assignees
@jasoncalabrese

Comments

@baswieb
Copy link

baswieb commented Feb 8, 2015

The prediction cone looks different in MMOL setting because the BG values are rounded to integer values. When the values are rounded to 1 decimal the prediction values look better in MMOL setting.
@jasoncalabrese jasoncalabrese self-assigned this Feb 9, 2015
@jasoncalabrese
Copy link
Member

@baswieb I think I have a fix, do you know how to test with different branches? I opened a PR with the fix #405

jasoncalabrese added a commit that referenced this issue Feb 9, 2015
@jasoncalabrese
Merge pull request #405 from nightscout/wip/mmol-cone-fix
45c1622 
don't round the predicted values when mmol display mode (fixes #402)
@jasoncalabrese
Copy link
Member

Will be part of the 0.6.3 release that will hopefully be out very soon

@baswieb
Copy link
Author

baswieb commented Feb 9, 2015

@jasoncalabrese Thanks! It's fixed

@jasoncalabrese jasoncalabrese mentioned this issue Feb 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasoncalabrese jasoncalabrese

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasoncalabrese @baswieb