Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAps features visible in pillar #6916

Open
maja-lofgren opened this issue Feb 22, 2021 · 1 comment
Open

OpenAps features visible in pillar #6916

maja-lofgren opened this issue Feb 22, 2021 · 1 comment

Comments

@maja-lofgren
Copy link

I just want to share a fiew tweeks that I've made to my NS that helps allot in visualizing important data.

Describe the solution you'd like
Modifications I've implemented:

  • IOB: Added the activity
  • COB: buggfix to show history COB when scrolling the timeline backwards
  • BASAL: added normal basal after current temp basal in "()"
  • OpenAPS: Added current Target (T), ISF, CR and sensibility ratio (sr)

image

Additional context
My code is not properly tested, and might fail if not used by AAPS.... more lika a proof of consept!
my branch diff against dev

@bjornoleh
Copy link
Contributor

Hi @maja-lofgren

I tested two of your individual commits now:

  • Fix to display historic COB-value (from OpenAps) when scolling back in time 7aa606d

  • Added profile basal rate in () next to current temp basal 58495f7

Both of these seems to work well here. Thanks for this!

We are not using AAPS, so can't test the "IOB: Added the activity" patch.

I also could not identify the relevant commit(s) for "OpenAPS: Added current Target (T), ISF, CR and sensibility ratio (sr)". I might test it later, but it will also take up a lot of space in NS (on a phone), so not sure if I 'd use it.

I am not involved in NS development, but would encourage you to prepare branches for your patches to allow PRs to NS dev. Please keep your PRs as small as possible, without bundling too much into each one. And start off with at clean branch that is even with dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants