Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to display historic COB-value (from OpenAps) when scolling back in time #8081

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bjornoleh
Copy link
Contributor

Copied from 7aa606d by @klalle / @maja-lofgren

Please see #6916 and #5241 for details.

@bjornoleh
Copy link
Contributor Author

The CI test failed at https://github.com/nightscout/cgm-remote-monitor/actions/runs/5924138923/job/16061111728#step:7:5346

COB
set a pill to the current COB:
TypeError: Cannot read properties of undefined (reading 'lastSuggested')
at Object.updateVisualisation (lib/plugins/cob.js:8:3117)
at Context. (tests/cob.test.js:95:9)
at processImmediate (node:internal/timers:466:21)

@bjornoleh
Copy link
Contributor Author

I don’t know if the proposed fix is a good one or a hack. But it has been working well for us using iAPS (previously called FreeAPS X). It should also work with AAPS, which is what this fix was targeted at by the original author. I don’t know if it would work with iOS DIY Loop

@bewest
Copy link
Member

bewest commented Aug 22, 2023

Excellent, looks like this will require a bit of work for loop as well. Great start on fixing this old bug!

@JohnKitching
Copy link

Is this still being worked on?
I'm not sure from the comments what it's waiting on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants