Disabled caching for /pebble

[brianhanifin]

and other dynamic elements.

[brianhanifin]

If I am correct, this /pebble header indicates no caching will happen. UPDATE: the page reloads as expected and is not cached.

HTTP/1.1 200 OK
content-type: application/json
Date: Wed, 25 Jun 2014 22:01:29 GMT
X-Powered-By: Express

[brianhanifin]

I believe this is ready to merge with the master!

[brianhanifin]

I also considered including some js/css minification. But since they are being gzipped by the server before being sent to the browser, and are being cached so darn well, I don't see any reason to complicate things further.

[brianhanifin]

Should this be merged into the master now?

Nevermind, somehow I missed your comment from yesterday ("Once Jason weighs in, I'm keen merge it in and get some people to try it out.")

[gregwaehner]

I agree that /pebble should not be cached, and thus, yes merged into master.

• Greg

From: Brian Hanifin [mailto:[email protected]]
Sent: Friday, June 27, 2014 6:56 PM
To: nightscout/cgm-remote-monitor
Subject: Re: [cgm-remote-monitor] Disabled caching for /pebble (#23)

Should this be merged into the master now?

—
Reply to this email directly or view it on GitHub #23 (comment) . https://github.com/notifications/beacon/7674953__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTUyODk3NywiZGF0YSI6eyJpZCI6MzU1NTQ4Njd9fQ==--0a29cd35a4ad5507d5928a0f78bda4845d17ca6e.gif

[brianhanifin]

Are you happy with the files being cached? I just realized I should have provided this list long ago. Is it too aggressive?

CACHE MANIFEST

CACHE:
http://localhost:1337/audio/alarm.mp3
http://localhost:1337/audio/alarm2.mp3
http://localhost:1337/css/dropdown.css
http://localhost:1337/css/main.css
http://localhost:1337/js/client.js
http://localhost:1337/js/dropdown.js
http://localhost:1337/favicon.ico
http://localhost:1337/bower_components/d3/d3.min.js
http://localhost:1337/bower_components/jquery/dist/jquery.min.js
http://fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,700italic,300,400,600,700,800
http://fonts.googleapis.com/css?family=Ubuntu:300,400,500,700,300italic,400italic,500italic,700italic

NETWORK:
*

# Fri Jun 27 2014 16:17:14 GMT-0700 (PDT)

[gregwaehner]

I looked in the server.js for the list - so I'm good with it. My only question for confirmation is -- where is it cached? On the back-end (server.js) or in the workstation client? The difference will drive instructions for how to clear the cache -- either restart your server.js, or clear your browser cache.

• Greg

From: Brian Hanifin [mailto:[email protected]]
Sent: Friday, June 27, 2014 7:29 PM
To: nightscout/cgm-remote-monitor
Cc: Greg Waehner
Subject: Re: [cgm-remote-monitor] Disabled caching for /pebble (#23)

Are you happy with the files being cached? I just realized I should have provided this list long ago. Is it too aggressive?

CACHE MANIFEST

CACHE:
http://localhost:1337/audio/alarm.mp3
http://localhost:1337/audio/alarm2.mp3
http://localhost:1337/css/dropdown.css
http://localhost:1337/css/main.css
http://localhost:1337/js/client.js
http://localhost:1337/js/dropdown.js
http://localhost:1337/favicon.ico
http://localhost:1337/bower_components/d3/d3.min.js
http://localhost:1337/bower_components/jquery/dist/jquery.min.js
http://fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,700italic,300,400,600,700,800
http://fonts.googleapis.com/css?family=Ubuntu:300,400,500,700,300italic,400italic,500italic,700italic

NETWORK:
*

Fri Jun 27 2014 16:17:14 GMT-0700 (PDT)

—
Reply to this email directly or view it on GitHub #23 (comment) . https://github.com/notifications/beacon/7674953__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTUzMDkzMSwiZGF0YSI6eyJpZCI6MzU1NTQ4Njd9fQ==--fb73425f8c8a9e596d40eb9dacdcf15d38e1c767.gif

[brianhanifin]

Greg, we are discussing this further. There is an opinion that perhaps only the audio files should be cached.

[bewest]

I think it's fine that the others are cached.

It's bonus.

On Sat, Jun 28, 2014 at 12:19 AM, Brian Hanifin [email protected]
wrote:

Greg, we are discussing this further. There is an opinion that perhaps
only the audio files should be cached.

—
Reply to this email directly or view it on GitHub
#23 (comment)
.

[brianhanifin]

Please consider the newer pull request for the master branch.