make sure all alarms are cleared #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes bug where only the first alarm was clear but both urgent and warning were playing
jasoncalabrese
added a commit
that referenced
this pull request
Jan 12, 2015
make sure all alarms are cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where only the first alarm was clear but both urgent and warning were playing
Currently if an urgent alarm goes un-ack'd, and then the condition improves some causing the warning alarm to trigger both sounds will play. When the user ack's the alarms only 1 of the alarms will stop. They would then have to restart the browser to stop the other alarm.