Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates to fix Azure deploys. #3476

Closed
wants to merge 1 commit into from

Conversation

telma2006
Copy link

Fix npm version 5.6.x.
Reverse the --production and --scripts-prepend-node-path arguments on npm install.
Use [email protected] to solve missing internal/util/types in postinstall.
Remove blank line in webpack.config.js as a dummy commit for postinstall testing.

@PieterGit
Copy link
Contributor

Great to get Azure fixed. Please target changes to dev branch instead of master. Please check why these changes break the unit test. You might be able to use #3413 as that also updates quite some packages.

Fix npm version 5.6.x.
Reverse the --production and --scripts-prepend-node-path arguments on npm install.
Use [email protected] to solve missing internal/util/types in postinstall.
Remove blank line in webpack.config.js as a dummy commit for postinstall testing.
@balshor
Copy link
Contributor

balshor commented Jun 25, 2018

I've created a pull request for dev here: #3642

@PieterGit
Copy link
Contributor

Closing this PR. Updates must be targeted at the dev branch and not at the master branch. See #3642 3642

@PieterGit PieterGit closed this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants