Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only show the alarm threshold values in the alarm setting when simple mode is enabled #360

Merged
merged 7 commits into from
Jan 24, 2015

Conversation

jasoncalabrese
Copy link
Member

screen shot 2015-01-21 at 6 24 34 pm

screen shot 2015-01-21 at 6 24 54 pm

@jasoncalabrese
Copy link
Member Author

@jimsiff you can target your heroku deploy button changes here

@jimsiff
Copy link
Contributor

jimsiff commented Jan 22, 2015

@jasoncalabrese @gregwaehner I created two new Heroku deploy branches. The first uses the same changes from yesterday where ALARM_TYPES was hard set to 'predict' because the BG_* values were hard set to their implied default. That deploy behavior works, but it's not the cleanest because it hard sets variables that don't need to be set.

The second branch leaves all alarm related variables blank with simple descriptions that highlight the implied default. I think the second approach is cleaner and the site deploys as originally intended with implied defaults.

Or, we can leave these variables completely out of the Heroku deployment and have users manually create and define any optional variables. If we follow that approach to it's logical conclusion, should we then also remove the enable and pushover related variables too? It's a balance between simplicity vs flexibility.

See the pics below:

Explicitly set variables

screen shot 2015-01-22 at 1 06 34 pm

Implicitly set variables

screen shot 2015-01-22 at 1 10 21 pm

@jasoncalabrese
Copy link
Member Author

The 2nd image with the empty values and defaults in the description make sense to me

@jimsiff
Copy link
Contributor

jimsiff commented Jan 23, 2015

PR #364 used the empty values and defaults in the description.

jasoncalabrese added a commit that referenced this pull request Jan 24, 2015
only show the alarm threshold values in the alarm setting when simple mode is enabled
@jasoncalabrese jasoncalabrese merged commit a4d8b93 into dev Jan 24, 2015
@jasoncalabrese jasoncalabrese deleted the wip/alarm-types-update branch January 24, 2015 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants