Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node v0.12 to travis #417

Merged
merged 1 commit into from
Feb 25, 2015
Merged

Conversation

dduugg
Copy link
Contributor

@dduugg dduugg commented Feb 15, 2015

resolves #414

@dduugg
Copy link
Contributor Author

dduugg commented Feb 15, 2015

Continuation of #415

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.82% when pulling 8ddbf09 on dduugg:wip/travis into 57c8e99 on nightscout:dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.82% when pulling 1ddb6df on dduugg:wip/travis into 57c8e99 on nightscout:dev.

@dduugg dduugg closed this Feb 15, 2015
@dduugg dduugg reopened this Feb 15, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.82% when pulling 2242725 on dduugg:wip/travis into 57c8e99 on nightscout:dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.82% when pulling 08867eb on dduugg:wip/travis into 57c8e99 on nightscout:dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.82% when pulling 08867eb on dduugg:wip/travis into 57c8e99 on nightscout:dev.


report:
test -f ${ANALYZED} && \
(npm install coveralls && cat ${ANALYZED} | \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent doesn't look right here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, there were mixed spaces & tabs too.

@jasoncalabrese
Copy link
Member

some nice cleanup and we learned a few things too 👍

add tests for node v0.12
move coveralls to after_script (prevents coveralls from failing travis)
use project installs of mocha and istanbul exclusively

resolves nightscout#414
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.82% when pulling ecdabe8 on dduugg:wip/travis into 57c8e99 on nightscout:dev.

@dduugg dduugg closed this Feb 16, 2015
@dduugg dduugg reopened this Feb 16, 2015
@dduugg dduugg closed this Feb 16, 2015
@dduugg dduugg reopened this Feb 16, 2015
@jasoncalabrese
Copy link
Member

I'll plan to get this in with your other PR soon

jasoncalabrese added a commit that referenced this pull request Feb 25, 2015
@jasoncalabrese jasoncalabrese merged commit cc812e4 into nightscout:dev Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants