Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return the last Cal entry (don't worry about how old it might be) #476

Merged
merged 13 commits into from
Mar 14, 2015

Conversation

jasoncalabrese
Copy link
Member

Also some refactoring by using async.parallel to make multiple ongo requests at once.

Bonus fix: also check env.DISPLAY_UNITS if the units query string param isn't set

@bewest @ELUTE @jimsiff

… of the callback-hell; also use env.DISPLAY_UNITS if units aren't set on request
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.18%) to 71.34% when pulling d08f5f7 on wip/last-cal into 1e27704 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.25%) to 72.77% when pulling 2dc7536 on wip/last-cal into 1e27704 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.37%) to 72.89% when pulling 6357212 on wip/last-cal into 1e27704 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 72.73% when pulling 7b6f054 on wip/last-cal into 1e27704 on dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 72.73% when pulling 7b6f054 on wip/last-cal into 1e27704 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 72.69% when pulling 896ae9e on wip/last-cal into ebcb49c on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 72.69% when pulling 3162422 on wip/last-cal into ebcb49c on dev.

@jasoncalabrese
Copy link
Member Author

@jimsiff, @ELUTE, I talked to @YYGIRL about some users are burning through data partially due to the extra cal data returned from /pebble. We merged in a fix (6357212) that selectively chooses the fields that are needed. The plan is to have some of those users that are most concerned about data usage to start using dev after this PR is merged. Then they can also help test before we release Enchilada to master.

@jimsiff
Copy link
Contributor

jimsiff commented Mar 13, 2015

JSON payload is reduced about 40% but TCP and HTTP protocol overhead drops the net savings to 20%. Gzip encoding may help some more.

@jasoncalabrese
Copy link
Member Author

thanks for testing @jimsiff did you also take a look at the main web monitor page, in addition to /pebble?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 72.69% when pulling b7fc6b9 on wip/last-cal into ebcb49c on dev.

@jasoncalabrese
Copy link
Member Author

I just added gzip compression to everything, with that we're down to 255 bytes (455 with http overhead)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 72.69% when pulling 206a8fd on wip/last-cal into ebcb49c on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 72.69% when pulling bcd3fa0 on wip/last-cal into ebcb49c on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 72.69% when pulling a1f963a on wip/last-cal into ebcb49c on dev.

jasoncalabrese added a commit that referenced this pull request Mar 14, 2015
Always return the last Cal entry (don't worry about how old it might be)
@jasoncalabrese jasoncalabrese merged commit 77f0fdc into dev Mar 14, 2015
@jasoncalabrese jasoncalabrese deleted the wip/last-cal branch March 15, 2015 19:28
@jasoncalabrese jasoncalabrese modified the milestone: enchilada Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants