Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load absolute dosing from amount field #5980

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Load absolute dosing from amount field #5980

merged 1 commit into from
Sep 14, 2020

Conversation

sulkaharo
Copy link
Member

Alternate implementation for #5740

@sulkaharo sulkaharo changed the base branch from master to dev September 12, 2020 07:39
@sulkaharo sulkaharo mentioned this pull request Sep 12, 2020
Closed
bewest
bewest approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@bewest bewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. 🚢

@sulkaharo sulkaharo merged commit 345b171 into dev Sep 14, 2020
@sulkaharo sulkaharo deleted the absolute_amount branch September 14, 2020 13:08
@sethgagnon
Copy link

Does this mean that TDD in the reports is now accurate for omnipod users? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bewest bewest bewest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sulkaharo @sethgagnon @bewest