Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trend Arrow and Mobile Alarm fixes #7

Merged
merged 11 commits into from
Jun 20, 2014
Merged

Conversation

jasoncalabrese
Copy link
Member

My goals with the pull request are pretty big, so this may take some time... have changed so that a reduced scope can be made available sooner

  • port over all fixes from my fork
  • add support for trend arrows if available
  • UI to enable audio alarm on mobile browsers

@jasoncalabrese jasoncalabrese changed the title The initial commonization Commonizing the forks so we can have the best of both and give users more control Jun 7, 2014
@jasoncalabrese
Copy link
Member Author

Trend direction and ✓♪ mobile browser alarm workaround screen shot 2014-06-06 at 11 09 21 pm

@bewest bewest mentioned this pull request Jun 12, 2014
@jasoncalabrese jasoncalabrese changed the title Commonizing the forks so we can have the best of both and give users more control Trend Arrow and Mobile Alarm fixes Jun 15, 2014
@jasoncalabrese
Copy link
Member Author

I'm planning to merge this tonight, let me know if you don't agree.

The only thing I'm not happy with is the ✓♪ workaround. If anyone has a simple alternative I'd be happy to do something different, but won't have much time to work on it so it could cause a big delay.

@brianhanifin
Copy link
Contributor

What about Unicode speakers icon. It can disappear after the user clicks to enable the audio. U+1F507 

Well, shoot, that icon disappeared right after I submitted the form. We may have to use a little icon. Maybe I can work on that today.

http://www.fileformat.info/info/unicode/char/search.htm?q=Speaker&preview=entity

@gregwaehner
Copy link
Contributor

I'm all for it. I've been using the feature/commonize branch and I think you've done an amazing job.

-G

From: Jason Calabrese [mailto:[email protected]]
Sent: Thursday, June 19, 2014 10:38 AM
To: nightscout/cgm-remote-monitor
Subject: Re: [cgm-remote-monitor] Trend Arrow and Mobile Alarm fixes (#7)

I'm planning to merge this tonight, let me know if you don't agree.

The only thing I'm not happy with is the ✓♪ workaround. If anyone has a simple alternative I'd be happy to do something different, but won't have much time to work on it so it could cause a big delay.


Reply to this email directly or view it on GitHub #7 (comment) . https://github.com/notifications/beacon/7674953__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxODgwNzkwNywiZGF0YSI6eyJpZCI6MzQwOTAzODl9fQ==--e8f6706ad618313c1625f52b68c580fcdb8be29a.gif

jasoncalabrese added a commit that referenced this pull request Jun 20, 2014
Trend Arrow and Mobile Alarm fixes
@jasoncalabrese jasoncalabrese merged commit 0bebebe into master Jun 20, 2014
@jasoncalabrese jasoncalabrese deleted the feature/commonize branch June 20, 2014 04:01
brianhanifin added a commit that referenced this pull request Jul 2, 2014
Merging new nightscout master
MilosKozak pushed a commit that referenced this pull request Nov 11, 2016
MilosKozak pushed a commit that referenced this pull request Feb 10, 2017
sulkaharo pushed a commit that referenced this pull request Sep 11, 2017
tanja3981 referenced this pull request in tanja3981/cgm-remote-monitor Apr 29, 2018
MilosKozak pushed a commit that referenced this pull request Dec 4, 2018
Update fork (dev) 181121
jjasonbell82 referenced this pull request in jjasonbell82/cgm-remote-monitor Oct 2, 2019
cominixo pushed a commit to cominixo/cgm-remote-monitor that referenced this pull request Mar 1, 2021
mrspouse pushed a commit to mrspouse/cgm-remote-monitor that referenced this pull request Apr 3, 2022
bewest pushed a commit that referenced this pull request Jun 30, 2022
justinthomas pushed a commit to justinthomas/cgm-remote-monitor that referenced this pull request Nov 29, 2022
hydroxy pushed a commit to hydroxy/cgm-remote-monitor that referenced this pull request Dec 3, 2022
DarynGit added a commit to DarynGit/cgm-remote-monitor that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants