Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias subscription to /downloads/$username/protobuf #713

Merged
merged 12 commits into from
Jul 22, 2015

Conversation

bewest
Copy link
Member

@bewest bewest commented Jul 17, 2015

/downloads/$username/protobuf is alias for /downloads/protobuf

/downloads/$username/protobuf is alias for /downloads/protobuf
@codecov-io
Copy link

Current coverage is 81.14%

Merging #713 into dev will increase coverage by +1.02% as of e73ba7c

@@              dev    #713   diff @@
=====================================
  Files          46      46       
  Stmts        2430    2444    +14
  Branches      486     488     +2
  Methods       380     380       
=====================================
+ Hit          1947    1983    +36
+ Partial        18      17     -1
+ Missed        465     444    -21

Review entire Coverage Diff


Uncovered Suggestions

  1. +0.57% via lib/mqtt.js#128...141
  2. +0.53% via lib/treatments.js#18...30
  3. +0.49% via lib/utils.js#31...42
  4. See 7 more...

Powered by Codecov

@codecov-io
Copy link

Current coverage is 84.02%

Merging wip/shared-mqtt into dev will decrease coverage by -0.36% as of 5317a83

@@              dev   wip/shared-mqtt   diff @@
===============================================
  Files          46                46       
  Stmts        2477              2434    -43
  Branches      503               489    -14
  Methods       378               368    -10
===============================================
- Hit          2090              2045    -45
+ Partial        19                17     -2
- Missed        368               372     +4

Review entire Coverage Diff


Uncovered Suggestions

  1. +0.57% via lib/mqtt.js#128...141
  2. +0.49% via lib/utils.js#31...42
  3. +0.49% via lib/mqtt.js#292...303
  4. See 7 more...

Powered by Codecov

@jasoncalabrese
Copy link
Member

fixed test and a bug too

@bewest
Copy link
Member Author

bewest commented Jul 19, 2015

Wow, very nice.

@Fokko
Copy link
Contributor

Fokko commented Jul 19, 2015

Looks great! Love the ISO time format.

@jasoncalabrese jasoncalabrese modified the milestone: f-release Jul 21, 2015
jasoncalabrese added a commit that referenced this pull request Jul 22, 2015
alias subscription to /downloads/$username/protobuf
@jasoncalabrese jasoncalabrese merged commit 5b8882b into dev Jul 22, 2015
@jasoncalabrese jasoncalabrese deleted the wip/shared-mqtt branch July 22, 2015 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants