Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Profile Editor #787

Merged
merged 17 commits into from
Aug 16, 2015
Merged

Extend Profile Editor #787

merged 17 commits into from
Aug 16, 2015

Conversation

jasoncalabrese
Copy link
Member

Building on @MilosKozak's #782 this will add some basic tests, link from the settings page, and other minor changes

@codecov-io
Copy link

Current coverage is 82.07%

Merging #787 into dev will decrease coverage by -0.24% as of 1aa8a67

@@              dev    #787   diff @@
=====================================
  Files          55      60     +5
  Stmts        3516    4011   +495
  Branches        0       0       
  Methods         0       0       
=====================================
+ Hit          2894    3292   +398
  Partial         0       0       
- Missed        622     719    +97

Review entire Coverage Diff as of 1aa8a67

Uncovered Suggestions

  1. +0.35% via lib/mqtt.js#128...141
  2. +0.30% via ...rofile/js/profile.js#321...332
  3. +0.30% via lib/mqtt.js#292...303
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@jasoncalabrese
Copy link
Member Author

next is to replace the XMLHttpRequest based post of the mockable $.ajax post, then we can verify post and by tinkering with the dom to simulate user edits.

@jasoncalabrese
Merge branch 'dev' into wip/profileeditor
589ced1
@jasoncalabrese
minor formatting while reading code
82d41fd
@jasoncalabrese
don't overwrite created_at durring save if it already exists
21e66ce
@jasoncalabrese
update icons and title
221d707
@jasoncalabrese
profile editor updates
dd319ca 
use $.ajax for PUT/POST (now easier to mock)
send saveDate as iso
don't sent the per GI fields unless they are enabled
click update button in test
jasoncalabrese
jasoncalabrese reviewed Aug 15, 2015
View reviewed changes
static/profile/js/profile.js
return true;
}

function addSingleLine(e,i) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: This function's cyclomatic complexity is too high. (8)

@jasoncalabrese jasoncalabrese changed the title Extend Profile Editor tests Extend Profile Editor Aug 15, 2015
@jasoncalabrese
Copy link
Member Author

Added link from settings if any related plugins are enabled

screen shot 2015-08-15 at 2 03 18 pm

@francescaneri
Copy link
Contributor

@jasoncalabrese you can add the plug-in battery?

@jasoncalabrese jasoncalabrese added this to the f-release milestone Aug 16, 2015
jasoncalabrese added a commit that referenced this pull request Aug 16, 2015
@jasoncalabrese
Merge pull request #787 from nightscout/wip/profileeditor
6170489 
Extend Profile Editor
@jasoncalabrese jasoncalabrese merged commit 6170489 into dev Aug 16, 2015
@jasoncalabrese jasoncalabrese deleted the wip/profileeditor branch August 16, 2015 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0 (Funnel Cake)
Development

Successfully merging this pull request may close these issues.
4 participants
@jasoncalabrese @codecov-io @francescaneri @MilosKozak