Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.io: enable legacy v2 connections #8127

Merged
merged 3 commits into from
Oct 22, 2023
Merged

socket.io: enable legacy v2 connections #8127

merged 3 commits into from
Oct 22, 2023

Conversation

bewest
Copy link
Member

@bewest bewest commented Oct 21, 2023

The allowEIO3, when set to true allows v2 clients to connect while the default is false. This patch should allow versions of AndroidAPS older than 3.2 to connect to NS15 and above.
Thanks to Dave Carlson for researching and experimenting with this option!
https://socket.io/docs/v4/migrating-from-2-x-to-3-0/#how-to-upgrade-an-existing-production-deployment https://socket.io/docs/v4/server-options/#alloweio3

The allowEIO3, when set to true allows v2 clients to connect while the
default is false. This patch should allow versions of AndroidAPS older
than 3.2 to connect to NS15 and above.
Thanks to Dave Carlson for researching and experimenting with this
option!
https://socket.io/docs/v4/migrating-from-2-x-to-3-0/#how-to-upgrade-an-existing-production-deployment
https://socket.io/docs/v4/server-options/#alloweio3
@bewest
Copy link
Member Author

bewest commented Oct 22, 2023

Same as #8126

Dave Carlson and others added 2 commits October 21, 2023 17:46
This patch removes my own patch to enable allowEIO3 in
favor of @thecubic's patch. They both do the same thing, but
@thecubic's is tested.
@bewest bewest merged commit 73c8089 into dev Oct 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant