Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct APIv3 handling of multiple filter parameters for a single field #8252

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bniels707
Copy link

Previously, only the last filter parameter for a field would be applied. After this change, filter parameters for fields are aggregated instead of being replaced.

This allows for range queries, ex: date$gt=1491719030000&date$lt=1491719930000

Additional tests were added to both verify the new behavior as well as to verify other documented API functionality, such as the use of ISO8601 dates.

Previously, only the last filter parameter for a field would be applied.
After this change, filter parameters for fields are aggregated instead
of being replaced.

Additional tests were added to both verify the new behavior as well as
to verify other documented API functionality, such as the use of ISO8601
dates.

This allows for range queries, ex: date$gt=1491719030000&date$lt=1491719930000
@bniels707
Copy link
Author

The API version should probably be incremented after accepting this, or it could be added to this MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant