return generic '500' status on bootError page #8296
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daaanosaur
commented
Sep 24, 2024
| @@ -29,7 +29,7 @@ function bootError(env, ctx) { | |||
| return '<dt><b>' + obj.desc + '</b></dt><dd>' + message.replace(/\\n/g, '<br/>') + '</dd>'; | |||
| }).join(' '); | |||
|
|
|||
| res.render('error.html', { | |||
| res.status(500).render('error.html', { | |||
There was a problem hiding this comment.
https://expressjs.com/en/api.html#res.status
This returns a 500 error http status in the header, rather than the default 200 ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Nightscout Web Monitor does not return a HTTP error status code when displaying the
bootErrorpage.This means that while users can see there is a problem with the application, platforms it may be deployed on cannot.
Returning a 500 status error in this case will at least enable health checks to be performed and deployments to be restarted when there's an issue with the application.