Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meals/insulin and BG checks #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stijnbrouwers
Copy link
Contributor

Related to request #38

This PR will add insulin/meal treatments into NightScout as well as BG Checks

@bewest
Copy link
Member

bewest commented Jul 2, 2023

This looks really helpful, thank you!

We are moving the plugin code to another repository, would you feel comfortable targeting nightscout-connect instead? https://github.com/nightscout/nightscout-connect

@stijnbrouwers
Copy link
Contributor Author

@bewest I wasn't aware of the other project tbh.
I will need to take a closer look to see how much work it would take to target the other repo.
However, I don't see the opportunity for it in the near future.

Might be an interesting project somewhere further down the line for me :-)

@bewest
Copy link
Member

bewest commented Aug 14, 2023

Ok, I've brought much of your logic over to the new library: nightscout/nightscout-connect#19

Any additional notes, details? What are the MANUAL activationType? What about AUTO_MODE_STATUS, etc... What do extended deliveries look like?
Thanks!

@stijnbrouwers
Copy link
Contributor Author

@bewest , looks good!

I am not really sure about the other types myself.
I only focused on the meals and fingerpricks for now and would need to do some testing myself on the other stuff...

Thanks for porting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants