Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove biosample.assay_type #7

Open
jonathancrabtree opened this issue Sep 20, 2022 · 2 comments
Open

Remove biosample.assay_type #7

jonathancrabtree opened this issue Sep 20, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jonathancrabtree
Copy link
Contributor

Remove all references to biosample.assay_type; it will be removed from the C2M2 specification and schema.

@jonathancrabtree jonathancrabtree added the enhancement New feature or request label Sep 20, 2022
@jonathancrabtree jonathancrabtree self-assigned this Sep 20, 2022
@jonathancrabtree
Copy link
Contributor Author

It looks like cfde_fair:12 ("biosamples with assay") is the only metric affected by this change. As an aside, this metric was previously calculated by joining through file and examining file.assay_type instead of biosample.assay_type. So we could potentially revert to the original formulation, but that query was inconsistent with at least one other in the set (probably files with assay) and so I think it makes more sense to simply remove cfde_fair:12.

@jonathancrabtree
Copy link
Contributor Author

Current metrics display (prior to rolling out the biosample.assay_type deletion). Note the 3rd metric in the left column, "biosamples with assay":

Screen Shot 2022-09-22 at 3 19 28 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant