Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework -a Option #47

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Rework -a Option #47

merged 1 commit into from
Sep 2, 2024

Conversation

Cyanistic
Copy link
Contributor

Reworks the -a option to show a drag all files button instead of always dragging all files together. (#33)

-a option now shows a drag all button at the top of the file list
instead of always dragging all files

fix warnings

fix comment
@nik012003
Copy link
Owner

nik012003 commented Sep 2, 2024

Thank you so much! It looks good, there's only one small issue:
-at or -atk are broken since we do setup_drop_target() when we create ListWidget , and it seems like appending list.widget on the outer_box doesn't make the drop target work for some reason.
I tried debugging it quickly and found out that my assumptions were correct and that putting something like

    let outer_box = outer_box.upcast::<Widget>();

    setup_drop_target(&list.list_model, &outer_box);

at the end of the create_outer_box() function works. (but you'd need to change the function return type to Widget instead of Box. I guess the best way would be to call setup_drop_target() directly in the main when we build the UI.

EDIT: alright, should be fixed in my commit, thank you!

@nik012003 nik012003 merged commit e9d73fb into nik012003:master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants