-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated Optional parameter before required parameter on PrintableNewAnonClassNode #987
Conversation
…bleNewAnonClassNode Fixes nikic#986
Ready to merge 👍 |
Would this error be detected by a php lint CI job? If so, would be great to add such github actions |
On rector-src, we use list of classes as preload, and error detected early. I compared to php-parser v5, it seems |
I don't question your fix. was only thinking about some CI tooling for this PR here to make sure we can detect such errors in the future earlier |
I don't see the deprecation warning printed on the PHP 8.2 and PHP 8.3 CI jobs at all -- I wonder why that is. I do see it when running with these versions locally. |
Fixes #986