Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the inconsisencies of HTML element with both box-shadow and border-radius #2367

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hybtalented
Copy link

Summary

This PR fixes the unexpect rendering of HTML element with box-shadow and border-radius styles. It also improve the performance of box-shadow with inset property.

here is the contract while the issues has been sovled:
no border origin
origin html without border
no border render
render by html2canvas without border
border origin
origin html with border
no border render
render by html2canvas with border
Closing issues

Fixes #1987
maybeFixed #1856 (I can't assess the jsfiddle, so it not clear whether it was fixed.)

@hybtalented
Copy link
Author

hybtalented commented Oct 23, 2020

Summary

This PR fixes the unexpect rendering of HTML element with box-shadow and border-radius styles. It also improve the performance of box-shadow with inset property.

no border origin
origin html without border
no border render
render by html2canvas without border
border origin
origin html with border
no border render
render by html2canvas with border

Closing issues

Fixes #1987
maybeFixed #1856 (I can't assess the jsfiddle, so it not clear whether it was fixed.)

It looks like the pictures have been down. The effect of the changes can be test in the test page http://localhost:8080/tests/reftests/background/box-shadow.html

@trollr
Copy link

trollr commented Jun 10, 2021

@niklasvh could you please merge this one :) That would be great

@abdurrahmanyildirim
Copy link

abdurrahmanyildirim commented Sep 8, 2021

@niklasvh This solution works well. Could you merge this?

@cyan-2048
Copy link

hi i need this, any way to get a copy of a compiled JS file for this fork?

@makidoll
Copy link

I'd like this merged too!

@Mamezou-zhang-yong
Copy link

I'd like this merged too, would you have any schedule to merge it.

@bastienlemaitre
Copy link

@niklasvh ?

@Inviz
Copy link

Inviz commented Mar 2, 2023

I tried this branch and the shadows still look pretty strangely, but it's better. However the "maybefix" part is not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behavior of box-shadow and inset
8 participants