passthru-vendored.nix: add configurePhase to enable compatibility with crane #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility with "crane" by simply adding the
configurePhaseto thephasesin the vendored passthru for rust packages.I currently cannot figure out why, but
craneseems to require this phase to properly vendor all required dependencies into the target directory (even though theconfigurePhaseis supposed to be empty).EDIT: Maybe it's this.
In my surface-level tests this did not break compatibility with other nix build tools such as the standard
buildRustPackage.