Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clinic: adds API endpoints and UI to list, search and view patients #3

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ashutoshgngwr
Copy link
Collaborator

@ashutoshgngwr ashutoshgngwr commented Oct 26, 2023

Also piggybacking some minor refactors.

TODO:

  • Fix remote API call handling: remote API requests trigger when Reagent render is invoked, and it is not ideal for scenarios where re-render doesn't change request parameters.

Because:
1. React components accept an OPTIONAL map of props as their first arguement.
2. If the first arg is not a map, it is considered a child.
3. Therefore, map destructuring the first arg won't work.
4. We can still use non-map props, e.g. `[component prop-1 prop-2 ...]`, but
   this isn't idea for components that want to accept children. Therefore,
   sticking to the optional-map-style props is consistent way to declare
   components.
@ashutoshgngwr ashutoshgngwr changed the title Adds API endpoints and UI to list, search and view patients Clinic: adds API endpoints and UI to list, search and view patients Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant