-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nim.cfg danger/release flags honored inconsistently #12349
Comments
nim's bundled cfg is evaluated before user/project one, so release and danger have no effect in them (compiler options are already set when user cfg is evaluated). |
The issue is that the compiler shouldn't report that it created a danger build when it hasn't. |
Should this be closed and added to #14272 or something? |
Perhaps we should wait until the problem is resolved to close the issue. |
timotheecour
added a commit
to timotheecour/Nim
that referenced
this issue
Oct 27, 2020
…imStrip honor user config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm writing a benchmark tool and I thought I would run it against the #12152 test. That code takes 13s without flags and 2.7s in
-d:release
and 2.0s in-d:danger
.When I set
-d:danger
in my nim.cfg, the compiler reports that it built aDangerous Release Build
but the code takes 13s. Indeed, the binary output is identical to that of a debug build.I've verified that the define is actually set and may be acted upon in the code with a
when
.The text was updated successfully, but these errors were encountered: