added []= value assignment for smart pointers #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planetis-m
reviewed
Dec 12, 2020
| @@ -51,6 +51,8 @@ proc `[]`*[T](p: UniquePtr[T]): var T {.inline.} = | |||
| assert(p.val != nil, "deferencing nil unique pointer") | |||
| p.val[] | |||
|
|
|||
| proc `[]=`*[T](p:UniquePtr[T], v:T) {.inline.} = (p[]) = v | |||
There was a problem hiding this comment.
can you please assign to p.val directly, seems wasteful to go through a function call
There was a problem hiding this comment.
oh its inline, so maybe no need to.
There was a problem hiding this comment.
Thanks for reviewing! Yeah, I made it inline in lieu of p.val since that was the existing design for the other procs. I just followed suit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass-by-reference (
var) was not used here because these additions are about changing the values pointed to by the pointers, regardless if the pointer itself is mutable. ConstPtr correctly yields an informative error on attempted value assignment.